Export string sets in monitoring infos.#31838
Merged
robertwb merged 3 commits intoapache:masterfrom Jul 11, 2024
Merged
Conversation
Contributor
Author
|
R: @Abacn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Contributor
|
Checkout this PR, removed excludeCategory in commonRunnerV2ExcludeCategories and ran is this expected? (there is still some gap to make this metrics available in PipelineResult |
Contributor
Author
Yes, there's still work to plumb the results back on the Dataflow service end. |
Abacn
approved these changes
Jul 11, 2024
| } | ||
| }); | ||
| stringSets.forEach( | ||
| (metricName, gaugeCell) -> { |
Contributor
There was a problem hiding this comment.
minor: gaugeCell -> stringSetSell
robertwb
added a commit
to robertwb/incubator-beam
that referenced
this pull request
Jul 11, 2024
3 tasks
jrmccluskey
pushed a commit
that referenced
this pull request
Jul 16, 2024
acrites
pushed a commit
to acrites/beam
that referenced
this pull request
Jul 17, 2024
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures they'll be available on Dataflow Runner v2.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.