Conversation
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
This change replaced the deprecated setup-gcloud@v0 to auth@v1 for the following tests: python test (fixed): https://github.com/apache/beam/actions/runs/9894928466 java test (fixed): https://github.com/apache/beam/actions/runs/9895714192 typescript test (permared): https://github.com/apache/beam/actions/runs/9895711562 build and version runner docker image (already passing): https://github.com/apache/beam/actions/runs/9895728848 This fixes current breakage on python test. Also tried to fix build_wheels and cleanUpGcpResource, not able to get them to work so reverted |
|
The reason build_wheel not work but python test worked was because the latter is running on self hosted runner, which comes with credential even not run auth action
|
|
R: @ahmedabu98 |
* Fix Python test auth * Replace more places setup-gcloud@v0 -> auth@v1 * add setup cloud * Revert change on build_wheels
* Fix Python test auth * Replace more places setup-gcloud@v0 -> auth@v1 * add setup cloud * Revert change on build_wheels
tested: https://github.com/apache/beam/actions/runs/9894928466
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.