[Prism] Support BundleFinalization DoFn parameter#32425
[Prism] Support BundleFinalization DoFn parameter#32425lostluck merged 11 commits intoapache:masterfrom
Conversation
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
lostluck
left a comment
There was a problem hiding this comment.
General comments since I know you have other plans for that remaining test right now.
lostluck
left a comment
There was a problem hiding this comment.
Minor changes and refactoring suggestions!
Please feel free to merge after you've made them, if you don't want another look.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32425 +/- ##
============================================
- Coverage 57.33% 57.32% -0.01%
Complexity 1474 1474
============================================
Files 964 965 +1
Lines 153301 153467 +166
Branches 1076 1076
============================================
+ Hits 87896 87981 +85
- Misses 63201 63281 +80
- Partials 2204 2205 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@lostluck The codecov/patch report shows stuff that didn't seem sensible to write tests for. Should I just go ahead and merge this you think? |
|
Agreed. Please go ahead |
* Support BundleFinalization DoFn parameter * Replace beam.Register with register.DoFn2x0 * Add TestParDoBundleFinalizer.* to filters * Register test funcs * Add filter to portable runner tests * Temporarily skip test * Simply tests; refactor per PR comments * Skip tests for not lookback mode * Clean up tests; add to coverage * Fix import ordering --------- Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>
This PR closes #31912 by adding support for bundle finalization via the
beam.BundleFinalizationDoFn parameter.With Prism running, to validate Java tests against Prism runner:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.