Fix beam.Row.__eq__ to ignore key order#32850
Closed
Polber wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
robertwb
reviewed
Oct 17, 2024
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Contributor
|
I'm not positive we want comparison to be order-independent, see e.g. the comments on #23876 |
Contributor
Author
Yeah it appears I totally missed a crucial comment It seems odd to me that order should matter on a schema'd data type, but I presume there is a use-case I'm not considering. In any case, I opened #32851 to fix the failing YAML tests |
Contributor
Author
|
Closing in favor of #32851 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beam Rows in the Python SDK are compared using an
__eq__method that considers the position of each key in the row. The case should be that order does not matter so long as all keys exists and have equal values of equal types.Fixes #32832
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.