[Do not merge] Change Reify.asIterable to GBK in BigQueryIO File loads#33284
Closed
Abacn wants to merge 1 commit intoapache:release-2.61.0from
Closed
[Do not merge] Change Reify.asIterable to GBK in BigQueryIO File loads#33284Abacn wants to merge 1 commit intoapache:release-2.61.0from
Abacn wants to merge 1 commit intoapache:release-2.61.0from
Conversation
Contributor
Author
Instruction to patchTo compile, need java11 and git in your bash. Checkout the project: git clone https://github.com/apache/beam.git --depth=1
cd beam
git fetch origin pull/33284/head:pr-33284
git switch pr-33284
git log # confirm current branch is on this patch
./gradlew -Ppublishing -p sdks/java/io/google-cloud-platform publishToMavenLocal
# check the jar published into your maven local repo
ls -l ~/.m2/repository/org/apache/beam/beam-sdks-java-io-google-cloud-platform/2.61.0-SNAPSHOT/
# -rw-r--r-- 1 ... 2620623 Dec 4 16:31 beam-sdks-java-io-google-cloud-platform-2.61.0-SNAPSHOT.jarThen in the pom.xml (for maven) or build.gradle (for gradle) project for the pipeline, change the version of org.apache.beam:beam-sdks-java-io-google-cloud-platform from 2.61.0 to 2.61.0-SNAPSHOT UPDATE: probably there is one more step need the change take effect, that is to add mavenLocal to the repository of your project. For maven, it should uses the mavanLocal by default. For gradle: |
Contributor
Author
|
note - there is a single test failing - testWriteEmptyPCollection[0] due to that the table won't get created by switching from ReifyAsIterable to GBK to combine list of files. The former will emit an empty list, while the later does not. |
Contributor
Author
|
superceded by #33587, which is based on master branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test only
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.