Conversation
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33457 +/- ##
============================================
- Coverage 59.08% 59.08% -0.01%
+ Complexity 3239 3237 -2
============================================
Files 1156 1156
Lines 176919 176907 -12
Branches 3391 3391
============================================
- Hits 104541 104532 -9
+ Misses 69011 69008 -3
Partials 3367 3367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
46ff528 to
3b66eca
Compare
3b66eca to
80a6938
Compare
|
@robertwb Please take a look. Thanks. |
80a6938 to
5aae10d
Compare
|
The two failure are unrelated to this change. |
robertwb
left a comment
There was a problem hiding this comment.
Hopefully we don't need this, but LGTM.
|
This change seems to break dataflow job submission. The job submit gets stuck after logging this message |
|
Commented too soon. I see the problem even after reverting this change locally. So it is not this change. |
|
That warning/error line can be ignored. It shows up for a all pipeline. It has tripped me over couple of times while working on metrics. I will look into where it comes from and removing it after the launch stuff. |
Add a flag to disable user bounded trie.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.