Revert "Add support for Iceberg table identifiers with special characters (#33293)"#33575
Revert "Add support for Iceberg table identifiers with special characters (#33293)"#33575Abacn merged 1 commit intoapache:masterfrom
Conversation
|
R: @ahmedabu98 cc: @regadas A forward fix could be
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
…ters (apache#33293)" This reverts commit d6e0b0c.
|
Hi @Abacn ouch, yeah adding cache makes sense to me! Can we avoid the revert if I put up a quick PR with it? Thx! |
|
@regadas thanks for prompt reply. Please do not worry about revert PR, it's just a generic practice to keep HEAD clean and keep linear history. Add it back is just a matter of another commit. Since #33293 is approved before I expect a forward fix PR can be reviewed much faster than the original PR. Take your time on fix and feel free to pin us if you have any question |
…cters (apache#33293)" (apache#33575) This reverts commit bb2e0ad.
…ters (apache#33293)" (apache#33575) This reverts commit d6e0b0c.
Reason: performance regression caught by internal tests (Iceberg write spends 100% more time)
half of time spends on IcebergUtils.parseTableIdentifier.
The code path suggests OBJECT_MAPPER.readTree always throws in my test case, and wasted most of time to assemble Exception object.
In general using try {} catch {} for what if clause does is an antipattern.
Possible forward fix could be using a cache.
This reverts commit d6e0b0c.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.