Report delta StringSet counters for streaming#33691
Report delta StringSet counters for streaming#33691jrmccluskey merged 2 commits intoapache:masterfrom
Conversation
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Currently working on fixing the unit test. |
|
Ran testRequestKeyedData_sendOnShutdownStreamThrowsWindmillStreamShutdownException locally and it passes. |
|
@robertwb Can you have a look? Thanks. |
|
LGTM. Test failure looks unrelated, re-running. There is a conflict that needs to be resolved as well. |
562c21f to
51465fb
Compare
|
Resolved merge conflicts. I do not have write permission on repo and hence wouldn't be able to merge. |
|
The failing test seem unrelated. |
|
This gets merged with beam_PreCommit_Java failing extractMetricUpdatesStringSet due to this change |
|
This breaks PreCommit Java. |
* Report delta StringSet counters from for streaming * Update unit test
|
Fixes #34052 |
* Report delta StringSet counters from for streaming * Update unit test
Report delta stringset metrics for streaming rather than cumulative.
Reporting cumulative was causing the following issues:
Tested that now we only see deltas
https://screenshot.googleplex.com/7W7R8Znv3mLgP8h
https://screenshot.googleplex.com/6GMLuRMe9zKrAMV
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.