add hashcode/equals to WaitTest helper classes to avoid log error by scwhittle · Pull Request #34006 · apache/beam

scwhittle · 2025-02-17T12:40:27Z

There are lots of error logs showing up otherwise.
See https://github.com/apache/beam/actions/runs/13367967271/job/37335398780?pr=33979 for example:

    [direct-runner-worker] WARN org.apache.beam.sdk.util.MutationDetectors - Coder of type class org.apache.beam.sdk.schemas.SchemaCoder has a #structuralValue method which does not return true when the encoding of the elements is equal. Element org.apache.beam.sdk.transforms.WaitTest$WindowExpirationValue@aaa632c
    [direct-runner-worker] WARN org.apache.beam.sdk.util.MutationDetectors - Coder of type class org.apache.beam.sdk.schemas.SchemaCoder has a #structuralValue method which does not return true when the encoding of the elements is equal. Element org.apache.beam.sdk.transforms.WaitTest$WindowExpirationValue@aaa632c
    [direct-runner-worker] WARN org.apache.beam.sdk.util.MutationDetectors - Coder of type class org.apache.beam.sdk.schemas.SchemaCoder has a #structuralValue method which does not return true when the encoding of the elements is equal. Element org.apache.beam.sdk.transforms.WaitTest$WindowExpirationValue@aaa632c
    [direct-runner-worker] WARN org.apache.beam.sdk.util.MutationDetectors - Coder of type class org.apache.beam.sdk.schemas.SchemaCoder has a #structuralValue method which does not return true when the encoding of the elements is equal. Element org.apache.beam.sdk.transforms.WaitTest$WindowExpirationValue@aaa632c
    [direct-runner-worker] WARN org.apache.beam.sdk.util.MutationDetectors - Coder of type class org.apache.beam.sdk.schemas.SchemaCoder has a #structuralValue method which does not return true when the encoding of the elements is equal. Element org.apache.beam.sdk.transforms.WaitTest$WindowExpirationValue@6cff1a6a
    [direct-runner-worker] WARN org.apache.beam.sdk.util.MutationDetectors - Coder of type class org.apache.beam.sdk.schemas.SchemaCoder has a #structuralValue method which does not return true when the encoding of the elements is equal. Element org.apache.beam.sdk.transforms.WaitTest$WindowExpirationValue@6cff1a6a

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

github-actions · 2025-02-17T13:37:17Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

scwhittle · 2025-02-17T13:45:55Z

Run Java_PVR_Prism_Loopback PreCommit

github-actions · 2025-02-17T14:36:54Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

m-trieu

LGTM

…ache#34006)

#34024) * #34009 avro generic record to beam row conversion added support for all logical types and conversions * using string comparison to avoid class not found issues with earlier versions of avro * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * Add `types.Unalias` to types assertions and types switches to get an underlying type instead of types.Alias (#33868) * Revert huggingface transformers to 4.30.0 (#34025) * add endpoint type to WorkerMetadataResponse proto (#33953) * add endpoint type to WorkerMetadataResponse proto * add default value to endpoint_type * add hashcode/equals to WaitTest helper classes to avoid log error (#34006) * Add enable_lineage experiment to Dataflow tests (#34027) * Add UUID support in SpannerSchema (#34034) * Add UUID support in Spanner Schema * Add test * fix dashboard link (#34023) * [Go SDK] Add missing type inspection case for Alias types. (#34039) * removed unneeded license header * remove unneeded license header * Added tests for specific records generated with avro 1.8.2 and 1.9.2, and to add custom conversions * Supporting different UUID representations in different avro versions * Spotless fixes * fix dependency typo --------- Co-authored-by: Alfredo Scaccialepre <alfredo.scaccialepre@edreamsodigeo.com> Co-authored-by: synenka <97878236+synenka@users.noreply.github.com> Co-authored-by: Vitaly Terentyev <vitaly.terentyev@akvelon.com> Co-authored-by: martin trieu <martinkt@google.com> Co-authored-by: scwhittle <scwhittle@users.noreply.github.com> Co-authored-by: Yi Hu <yathu@google.com> Co-authored-by: Luv Agarwal <luvagarwal.k@gmail.com> Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com> Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>

… for a… (apache#34024) * apache#34009 avro generic record to beam row conversion added support for all logical types and conversions * using string comparison to avoid class not found issues with earlier versions of avro * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * using string comparison to avoid class not found issues with earlier versions of avro * com.github.davidmc24.gradle.plugin:gradle-avro-plugin:1.9.1 * Add `types.Unalias` to types assertions and types switches to get an underlying type instead of types.Alias (apache#33868) * Revert huggingface transformers to 4.30.0 (apache#34025) * add endpoint type to WorkerMetadataResponse proto (apache#33953) * add endpoint type to WorkerMetadataResponse proto * add default value to endpoint_type * add hashcode/equals to WaitTest helper classes to avoid log error (apache#34006) * Add enable_lineage experiment to Dataflow tests (apache#34027) * Add UUID support in SpannerSchema (apache#34034) * Add UUID support in Spanner Schema * Add test * fix dashboard link (apache#34023) * [Go SDK] Add missing type inspection case for Alias types. (apache#34039) * removed unneeded license header * remove unneeded license header * Added tests for specific records generated with avro 1.8.2 and 1.9.2, and to add custom conversions * Supporting different UUID representations in different avro versions * Spotless fixes * fix dependency typo --------- Co-authored-by: Alfredo Scaccialepre <alfredo.scaccialepre@edreamsodigeo.com> Co-authored-by: synenka <97878236+synenka@users.noreply.github.com> Co-authored-by: Vitaly Terentyev <vitaly.terentyev@akvelon.com> Co-authored-by: martin trieu <martinkt@google.com> Co-authored-by: scwhittle <scwhittle@users.noreply.github.com> Co-authored-by: Yi Hu <yathu@google.com> Co-authored-by: Luv Agarwal <luvagarwal.k@gmail.com> Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com> Co-authored-by: Robert Burke <lostluck@users.noreply.github.com>

scwhittle requested a review from reuvenlax February 17, 2025 12:40

github-actions bot added the java label Feb 17, 2025

scwhittle mentioned this pull request Feb 17, 2025

Fix PostCommit Java Nexmark Dataflow job #33979

Merged

3 tasks

github-actions bot added the Next Action: Reviewers label Feb 17, 2025

add hashcode/equals to WaitTest helper classes to avoid log error

0558803

scwhittle force-pushed the schema_coder_structural branch from 8e07466 to 0558803 Compare February 19, 2025 10:04

m-trieu approved these changes Feb 19, 2025

View reviewed changes

scwhittle merged commit 91450ba into apache:master Feb 19, 2025
17 of 20 checks passed

scwhittle deleted the schema_coder_structural branch February 19, 2025 20:19

VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025

add hashcode/equals to WaitTest helper classes to avoid log error (ap…

b83bbab

…ache#34006)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add hashcode/equals to WaitTest helper classes to avoid log error#34006

add hashcode/equals to WaitTest helper classes to avoid log error#34006
scwhittle merged 1 commit intoapache:masterfrom
scwhittle:schema_coder_structural

scwhittle commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

scwhittle commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

m-trieu left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

scwhittle commented Feb 17, 2025

GitHub Actions Tests Status (on master branch)

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

scwhittle commented Feb 17, 2025

Uh oh!

github-actions bot commented Feb 17, 2025

Uh oh!

m-trieu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants