[DO NOT MERGE] Add support for collections dict subclasses#34254
[DO NOT MERGE] Add support for collections dict subclasses#34254jrmccluskey wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34254 +/- ##
=========================================
Coverage 56.32% 56.32%
Complexity 3286 3286
=========================================
Files 1172 1172
Lines 178933 178944 +11
Branches 3398 3398
=========================================
+ Hits 100778 100792 +14
+ Misses 74898 74895 -3
Partials 3257 3257
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
|
These changes were pulled in as part of Mapping support, closing |
Prototype for support for the dict subclasses in collections. Treats them as pure dictionaries for hint purposes, does not go further to validate the additional functions or set reasonable default types for bare cases (e.g. a bare Counter is treated as Dict[GenericKType, GenericVType] instead of Dict[GenericKType, int].)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.