Skip to content

Improve docstring for PGBKCVOperation #37946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 4 commits into from
Mar 26, 2026
Merged

Improve docstring for PGBKCVOperation #37946

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38fcbc0
Improve docstring for PGBKCVOperation
Subramanya-Veeregowda Mar 25, 2026
247d2f8
Fix docstring is satisfy lint
Subramanya-Veeregowda Mar 25, 2026
ff489b5
Add costring for PGBKCVOperation
Subramanya-Veeregowda Mar 25, 2026
85e8ffd
Revert untended .gitignore changes
Subramanya-Veeregowda Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,11 @@ playground/cloudfunction.zip
# as its generated with terraform
.test-infra/metrics/sync/github/github_runs_prefetcher/code.zip
.venv/


beam-env/
build/
*.pyc
__pycache__/
*.pyd
*.egg-info/
Copy link
Copy Markdown
Contributor

@damccorm damccorm Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of these are taken care of already in this file

Copy link
Copy Markdown
Contributor Author

@Subramanya-Veeregowda Subramanya-Veeregowda Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I’ll revert the .gitignore changes since they are already covered.

Copy link
Copy Markdown
Contributor Author

@Subramanya-Veeregowda Subramanya-Veeregowda Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reverted the .gitignore changes. Please let me know if anything else needs adjustment.

1 change: 0 additions & 1 deletion sdks/python/apache_beam/examples/snippets/transforms/aggregation/groupby_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
from .groupby_two_exprs import groupby_two_exprs



class UnorderedList(object):
def __init__(self, contents):
self._contents = list(contents)
Expand Down
5 changes: 5 additions & 0 deletions sdks/python/apache_beam/runners/worker/operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,6 +1234,11 @@ def flush(self, target):


class PGBKCVOperation(Operation):
"""Partial group-by-key operation.

This operation handles grouped values with
a combine function applied.
"""
def __init__(
self, name_context, spec, counter_factory, state_sampler, windowing=None):
super(PGBKCVOperation,
Expand Down
Loading