Skip to content

ClickHouseIO - align the RM with the test containers upgrade#37971

Merged
Abacn merged 2 commits intoapache:masterfrom
BentsiLeviav:clickhouse-adjust-testcontainers-credentials
Mar 26, 2026
Merged

ClickHouseIO - align the RM with the test containers upgrade#37971
Abacn merged 2 commits intoapache:masterfrom
BentsiLeviav:clickhouse-adjust-testcontainers-credentials

Conversation

@BentsiLeviav
Copy link
Copy Markdown
Contributor

Needed for version 2.72.0 release

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ClickHouse resource manager to align with recent Testcontainers upgrades. The changes streamline container setup by removing unnecessary wait strategies and ensure that JDBC connections are properly authenticated by incorporating credentials into the connection string.

Highlights

  • Testcontainers Configuration: Removed the explicit LogMessageWaitStrategy and simplified the container initialization process.
  • JDBC Connection String: Updated the JDBC connection string construction to include username and password credentials.
  • API Expansion: Added new public methods to retrieve the username and password from the ClickHouse resource manager.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@BentsiLeviav BentsiLeviav marked this pull request as draft March 26, 2026 16:17
@BentsiLeviav BentsiLeviav marked this pull request as ready for review March 26, 2026 18:00
Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Mar 26, 2026

Note: not necessarily requiring cherry-picked into 2.72 release as this is a test fixture issue we can fork the resource manager in DataflowTemplates repo

@Abacn Abacn merged commit 512c0fa into apache:master Mar 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants