Make MinRowCountForPageSizeCheck available with ValueProvider

[claudevdm]

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ParquetIO connector by introducing support for ValueProvider in the minRowCountForPageSizeCheck configuration. This change allows users to supply this parameter at runtime, which is a requirement for compatibility with classic Dataflow templates. The internal logic was updated to handle the potential nullability of the ValueProvider, ensuring robust integration with the existing Parquet writer configuration.

Highlights

• ValueProvider Support: Updated the ParquetIO Sink to support ValueProvider for the minRowCountForPageSizeCheck configuration, enabling runtime value injection.
• API Expansion: Added an overloaded withMinRowCountForPageSizeCheck method to the Sink class to accept ValueProvider.
• Logic Adjustment: Modified the open method to safely retrieve the value from the ValueProvider and apply it only if present.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claudevdm]

R: @Abacn

[claudevdm]

/gemini review

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[gemini-code-assist]

Code Review

This pull request updates ParquetIO.Sink to support ValueProvider<Integer> for the minRowCountForPageSizeCheck parameter, enabling runtime configuration for classic Dataflow templates. The review feedback suggests restoring the original default value instead of using null, adding validation for the ValueProvider at construction time when accessible, and implementing a runtime check to ensure the resolved value is positive.

[claudevdm]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates ParquetIO to support ValueProvider for the minRowCountForPageSizeCheck parameter, enabling runtime configuration for Beam pipelines. The review feedback identifies potential NullPointerExceptions when unboxing Integer values from the ValueProvider, recommending explicit null checks before validation and usage.

[claudevdm]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates ParquetIO.Sink to support ValueProvider for the minRowCountForPageSizeCheck parameter, allowing it to be configured at runtime for environments like Dataflow. The changes include updating the internal builder and adding an overloaded method to accept ValueProvider. A review comment suggests restoring the default value in the sink factory method by wrapping the existing constant in a StaticValueProvider to ensure consistent behavior and avoid potential null values.