Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms by jbonofre · Pull Request #38729 · apache/beam

jbonofre · 2026-05-28T15:19:22Z

Migrate JmsIO to jakarta.jms (JMS 3.1) with ActiveMQ 6.2.5 and qpid-jms-client 2.10.0. Replaces geronimo-jms_2.0_spec with jakarta.jms-api 3.1.0 and renames all javax.jms imports to jakarta.jms in main and test sources.

JmsIO now requires Java 17. AMQP and MQTT modules are unaffected (kept on ActiveMQ 5.19.2 via a separate activemq6_* library entry).

gemini-code-assist · 2026-05-28T15:19:37Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the JmsIO module by migrating from the legacy javax.jms namespace to the Jakarta Messaging API (jakarta.jms). This change involves updating core dependencies to versions that support the Jakarta EE standard, ensuring compatibility with modern messaging infrastructure.

Highlights

Dependency Upgrades: Updated ActiveMQ to 6.2.5 and qpid-jms-client to 2.10.0 to support modern JMS standards.
Jakarta EE Migration: Replaced the legacy geronimo-jms_2.0_spec with jakarta.jms-api 3.1.0 and migrated all javax.jms imports to jakarta.jms across the JmsIO module.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request migrates the JMS IO module from the legacy javax.jms namespace to the modern jakarta.jms namespace, upgrading ActiveMQ to 6.2.5, Qpid JMS Client to 2.10.0, and adopting jakarta.jms-api:3.1.0. The review feedback identifies critical Java compatibility issues with these upgrades: ActiveMQ 6.x requires Java 17, while Qpid JMS Client 2.x and Jakarta JMS API 3.1.0 require Java 11, which would break Apache Beam's Java 8 and Java 11 compatibility. The reviewer suggests downgrading the Jakarta JMS API to 3.0.0 to maintain Java 8 support and requests verification on how compatibility will be maintained for the other dependencies.

gemini-code-assist · 2026-05-28T15:20:36Z

    // There are a few versions are determined by the BOMs by running scripts/tools/bomupgrader.py
    // marked as [bomupgrader]. See the documentation of that script for detail.
-    def activemq_version = "5.19.2"
+    def activemq_version = "6.2.5"


ActiveMQ 6.x requires Java 17 as a minimum runtime version. Since Apache Beam still supports and runs tests on Java 8 and Java 11, upgrading activemq_version to 6.2.5 will cause test execution failures (such as UnsupportedClassVersionError) on Java 8 and Java 11 environments.

Please consider restricting the JmsIO tests to only run when the build JDK is 17 or higher, or verify how Java 8/11 compatibility will be maintained for the test suite.

gemini-code-assist · 2026-05-28T15:20:36Z

    // TODO(https://github.com/apache/beam/issues/37637): Remove this once the Bom has been updated to at least reach this version
    def bigtable_version = "2.73.1"
-    def qpid_jms_client_version = "0.61.0"
+    def qpid_jms_client_version = "2.10.0"


Qpid JMS Client 2.x requires Java 11 as a minimum runtime version. Since Apache Beam still supports Java 8, upgrading qpid_jms_client_version to 2.10.0 will break Java 8 compatibility for any users or tests utilizing this client. Please verify if this is intentional or if we need to restrict this dependency/module to Java 11+.

gemini-code-assist · 2026-05-28T15:20:36Z

  implementation library.java.slf4j_api
  implementation library.java.joda_time
-  implementation "org.apache.geronimo.specs:geronimo-jms_2.0_spec:1.0-alpha-2"
+  implementation "jakarta.jms:jakarta.jms-api:3.1.0"


jakarta.jms:jakarta.jms-api:3.1.0 (Jakarta Messaging 3.1) is compiled for Java 11 (class file version 55.0). Since Apache Beam still supports Java 8, using version 3.1.0 will break Java 8 compatibility for the beam-sdks-java-io-jms module.

To maintain Java 8 compatibility while migrating to the jakarta.jms namespace, please use jakarta.jms:jakarta.jms-api:3.0.0 (Jakarta Messaging 3.0), which is compiled for Java 8 (class file version 52.0).

implementation "jakarta.jms:jakarta.jms-api:3.0.0"

github-actions · 2026-05-28T18:05:12Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Bump activemq to 6.2.5 and qpid-jms-client to 2.10.0, both of which target jakarta.jms. Replace the geronimo-jms_2.0_spec dependency with jakarta.jms-api 3.1.0 and migrate all javax.jms imports and javadoc references in JmsIO main and test sources to jakarta.jms.

github-actions · 2026-06-22T23:03:43Z

Assigning reviewers:

R: @ahmedabu98 for label java.
R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damccorm

This generally seems fine, but trying to understand the goals. What benefits do we get from the upgrade? It does come at a Java version cost, so want to make sure we're making the right tradeoff.

cc/ @Abacn

damccorm · 2026-06-30T14:27:03Z

+// map. Because the global resolution strategy forces every mapped version,
+// that 6.2.5 would otherwise be forced onto this Java 11 module via the shared
+// org.apache.activemq coordinates. MQTT IO only needs ActiveMQ as an embedded
+// test broker, so pin it back to the Java 11-compatible 5.x line.


I see a couple of mentions of making this compatible with Java 11, but then we're forcing Java 17 - do we actually need to force Java 17 or can we just require Java 11?

ActiveMQ is a test dependency for AmqpIO, MqttIO, JmsIO. Instead of modifying build.gradle in the former ones, can we just pin to ActiveMQ 6 in JmsIO? This should give a smaller diff and safer as it doesn't do a global upgrade.

PS: I'm thinking about we should move our Infra to Java17 (probably Java21, to reduce the frequency of this kind of upgrade) while keep Java11 compatibility via cross-compilation. We already use Java21 to publish Javadoc

jbonofre · 2026-06-30T14:32:10Z

@damccorm the goal is to support the latest JMS spec version and so latest ActiveMQ version.

damccorm · 2026-06-30T19:36:58Z

Sounds good - I'm good with the change pending the one open comment thread

Abacn · 2026-07-01T15:59:43Z

Also, JmsIO used to have some weird checkpointing behavior to accommondate Jms spec

In JMS, acknowledging one message automatically acknowledges all messages processed by that specific session up to that point

This caused data loss due to Beam process and commit messages asynchronously. We ended up creating different sessions for each checkpointing: #30054

SInce this is a Jms spec upgrade, let me check if any breaking changes could happen especially checkpointing logics

github-actions Bot added java build io jms labels May 28, 2026

gemini-code-assist Bot reviewed May 28, 2026

View reviewed changes

jbonofre force-pushed the jms-activemq-6.2.5-jakarta branch 7 times, most recently from 52fe765 to dc7ebca Compare June 22, 2026 18:14

github-actions Bot added amqp mqtt labels Jun 22, 2026

jbonofre force-pushed the jms-activemq-6.2.5-jakarta branch from dc7ebca to a1f3ae2 Compare June 22, 2026 19:05

jbonofre force-pushed the jms-activemq-6.2.5-jakarta branch from a1f3ae2 to a85672c Compare June 22, 2026 20:33

github-actions Bot added the Next Action: Reviewers label Jun 22, 2026

jbonofre requested review from ahmedabu98, damccorm and kennknowles June 25, 2026 05:25

damccorm reviewed Jun 30, 2026

View reviewed changes

Abacn mentioned this pull request Jul 2, 2026

Bump CI Java version to Java21 #39205

Open

3 tasks

Uh oh!

Conversation

jbonofre commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented May 28, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

damccorm left a comment

Choose a reason for hiding this comment

Uh oh!

damccorm Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

jbonofre commented Jun 30, 2026

Uh oh!

damccorm commented Jun 30, 2026

Uh oh!

Abacn commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jbonofre commented May 28, 2026 •

edited

Loading

Abacn commented Jul 1, 2026 •

edited

Loading