[BEAM-3527] Adding a comment for ZERO element of DistributionResult.#4538
Merged
kennknowles merged 1 commit intoapache:masterfrom Feb 6, 2018
Merged
[BEAM-3527] Adding a comment for ZERO element of DistributionResult.#4538kennknowles merged 1 commit intoapache:masterfrom
kennknowles merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
+1 to changing your mind. Another alternative would be EMPTY. I though ZERO was the distribution with nothing but zeros in it. |
Contributor
|
@robertwb |
Member
Author
|
hmm how about we go with IDENTITY_ELEMENT ? |
Contributor
|
Sounds good to me! |
pabloem
force-pushed
the
comment-for-zero
branch
2 times, most recently
from
86d17e0 to
816e5da
Compare
pabloem
force-pushed
the
comment-for-zero
branch
from
816e5da to
957dcef
Compare
Member
Author
|
r: @kennknowles |
Member
|
SGTM LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've decided to not rename the ZERO, because I get the feeling that IDENTITY might be even less clear (though I'm open to having my mind changed:) ). I've only added a comment to clarify its purpose.
cc: @bjchambers
cc: @clairemcginty