TextIO.Write: use output directory with custom filenaming scheme#4710
Closed
gene-telligent wants to merge 2 commits intoapache:masterfrom
Closed
TextIO.Write: use output directory with custom filenaming scheme#4710gene-telligent wants to merge 2 commits intoapache:masterfrom
gene-telligent wants to merge 2 commits intoapache:masterfrom
Conversation
… a custom filenaming scheme
jkff
requested changes
Feb 20, 2018
Contributor
jkff
left a comment
There was a problem hiding this comment.
Thank you! Any chance you could add a test for this? I think it should be easy to extract the part that resolves fileNamingFn into a utility function, and add this case as a unit test.
…, and adding tests for it
Contributor
Author
|
Yep, no problem! Pulled the code into its own function and added some tests for it. Let me know if you have any further feedback! |
jkff
approved these changes
Feb 22, 2018
Contributor
jkff
left a comment
There was a problem hiding this comment.
Thanks! Will dedupe the test code a bit and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this while trying to write files (non dynamically) with a custom FileNaming.
Expected behavior: If an output directory is specified with a non-dynamic file write and a custom FileNaming, the generated filename should be resolved against the output directory.
Actual behavior: The output directory is ignored and the result of the FileNaming call becomes the full file path.
No JIRA ticket again because it looks like a quick code fix. @jkff once again can you take a quick look and approve?
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.