Skip to content

Make hash function in Coder base class more conservative.#5390

Closed
tvalentyn wants to merge 1 commit into
apache:masterfrom
tvalentyn:patch-13
Closed

Make hash function in Coder base class more conservative.#5390
tvalentyn wants to merge 1 commit into
apache:masterfrom
tvalentyn:patch-13

Conversation

@tvalentyn

Copy link
Copy Markdown
Contributor

[BEAM-3724]
Make hash function in Coder base class more conservative, to avoid evaluating hash based on potentially mutable collection.

DESCRIPTION HERE


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…aluating hash based on potentially mutable collection.
@tvalentyn

Copy link
Copy Markdown
Contributor Author

R: @RobbeSneyders

@tvalentyn

Copy link
Copy Markdown
Contributor Author

cc: @aaltay cc:@Fematich

@tvalentyn

Copy link
Copy Markdown
Contributor Author

retest this please

@RobbeSneyders

Copy link
Copy Markdown
Contributor

Seems like your coders.py file was renamed.

@tvalentyn

Copy link
Copy Markdown
Contributor Author

Thanks for taking a look, you are right. Looks like I need to get better control of my trackpad :) Closing this in favor of #5429

@tvalentyn tvalentyn closed this May 19, 2018
@tvalentyn tvalentyn deleted the patch-13 branch August 27, 2019 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants