Skip to content

[BEAM-4855] Added windowinto_microbenchmark#6051

Closed
Fematich wants to merge 1 commit into
apache:masterfrom
Fematich:transforms_microbenchmark
Closed

[BEAM-4855] Added windowinto_microbenchmark#6051
Fematich wants to merge 1 commit into
apache:masterfrom
Fematich:transforms_microbenchmark

Conversation

@Fematich

@Fematich Fematich commented Jul 24, 2018

Copy link
Copy Markdown
Contributor

Added microbenchmark for windowinto transform (as mentioned in #5729)

R: @tvalentyn

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@Fematich

Copy link
Copy Markdown
Contributor Author

I will reformat this microbenchmark to windowinto_microbenchmark that will test FixedWindow, SlidingWindow and Sessions similar to the used code now, I plan to update it tomorrow.

@Fematich Fematich changed the title [BEAM-4855] Added timestamped_value_microbenchmark [BEAM-4855] Added windowinto_microbenchmark Jul 24, 2018
@tvalentyn

tvalentyn commented Jul 25, 2018

Copy link
Copy Markdown
Contributor

Awesome, thank you! Did you see helpers in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/tools/utils.py? Consider using them to structure your microbenchmark to avoid code duplication related to measurements.
You could take a look at https://github.com/apache/beam/blob/master/sdks/python/apache_beam/tools/coders_microbenchmark.py as an example.

@tvalentyn

Copy link
Copy Markdown
Contributor

Also, if we are specifically intrested in testing performance of hashes and comparators, we can have a microbenchmark that does just that for the types you mentioned by doing something similar to https://github.com/tvalentyn/beam/blob/3f67f63377dd85a241a48b1108a618ebfbe891cb/sdks/python/apache_beam/tools/windowed_value_microbenchmark.py#L35. That code lives on my branch and I did not megre it to Beam, but you are more than welcome to use it if it helps.

@stale

stale Bot commented Sep 23, 2018

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale Bot added the stale label Sep 23, 2018
@stale

stale Bot commented Sep 30, 2018

Copy link
Copy Markdown

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale Bot closed this Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants