[BEAM-4855] Added windowinto_microbenchmark#6051
Conversation
|
I will reformat this microbenchmark to |
|
Awesome, thank you! Did you see helpers in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/tools/utils.py? Consider using them to structure your microbenchmark to avoid code duplication related to measurements. |
|
Also, if we are specifically intrested in testing performance of hashes and comparators, we can have a microbenchmark that does just that for the types you mentioned by doing something similar to https://github.com/tvalentyn/beam/blob/3f67f63377dd85a241a48b1108a618ebfbe891cb/sdks/python/apache_beam/tools/windowed_value_microbenchmark.py#L35. That code lives on my branch and I did not megre it to Beam, but you are more than welcome to use it if it helps. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Added microbenchmark for windowinto transform (as mentioned in #5729)
R: @tvalentyn
Post-Commit Tests Status (on master branch)