Several improvements for consistency of Python2 / Python3 conversions.#6144
Merged
Conversation
tvalentyn
force-pushed
the
py3_cleanups
branch
3 times, most recently
from
89656c6 to
f7a77bb
Compare
… autogenerated in Py3.
Contributor
Author
Contributor
Author
|
@Fematich would you have time to take a look at this PR before next week? |
Contributor
|
Looks good to me! I was only wondering if the change from |
Member
|
@Fematich |
Contributor
Author
aaltay
approved these changes
Aug 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BEAM-1251]
Use (str, future.builtins.unicode) where six.string_types was used in the past.
For Py2/Py3 compatibility, add complimentary ne methods which are autogenerated in Py3.
Use past.builtins.unicode where six.text_type was used.
Use bytes where six.binary_type was used.
Post-Commit Tests Status (on master branch)