Skip to content

Support specifying bookie http port as a command argument #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zymap merged 2 commits into from
Feb 9, 2022
Merged

Support specifying bookie http port as a command argument #2769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1139c12
Support specifying bookie http port as a command argument
fantapsody Aug 21, 2021
fdb992e
Added a short-hand option name 'hp' for 'httpport'
fantapsody Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public class Main {
BK_OPTS.addOption("z", "zkserver", true, "Zookeeper Server");
BK_OPTS.addOption("m", "zkledgerpath", true, "Zookeeper ledgers root path");
BK_OPTS.addOption("p", "bookieport", true, "bookie port exported");
BK_OPTS.addOption("hp", "httpport", true, "bookie http port exported");
BK_OPTS.addOption("j", "journal", true, "bookie journal directory");
Option indexDirs = new Option ("i", "indexdirs", true, "bookie index directories");
indexDirs.setArgs(10);
Expand Down Expand Up @@ -173,6 +174,13 @@ private static ServerConfiguration parseArgs(String[] args)
conf.setBookiePort(iPort.intValue());
}

if (cmdLine.hasOption("httpport")) {
String sPort = cmdLine.getOptionValue("httpport");
log.info("Get cmdline http port: {}", sPort);
Integer iPort = Integer.parseInt(sPort);
conf.setHttpServerPort(iPort.intValue());
}

if (cmdLine.hasOption('j')) {
String sJournalDir = cmdLine.getOptionValue('j');
log.info("Get cmdline journal dir: {}", sJournalDir);
Expand Down