Make sure the LedgerHandle close callback can be completed when encounter exception - #2913
Merged
Merged
Conversation
zymap
reviewed
Nov 29, 2021
| try { | ||
| errorOutPendingAdds(rc, pendingAdds); | ||
| } catch (Exception e) { | ||
| closePromise.completeExceptionally(e); |
Member
There was a problem hiding this comment.
If there has an exception, do we still need to do the tearDownWriteHandleState() and MetadataUpdateLoop operations?
Contributor
There was a problem hiding this comment.
Yes, it still needs the following operations. Catch this exception just to ensure the closePromise can complete.
Contributor
There was a problem hiding this comment.
we shouldn't "completeExceptionally" or "complete" the closePromise twice
hangc0276
requested review from
dlg99,
eolivelli,
hangc0276,
hezhangjian,
nicoloboschi and
zymap
July 25, 2022 01:58
hangc0276
approved these changes
Jul 26, 2022
| try { | ||
| errorOutPendingAdds(rc, pendingAdds); | ||
| } catch (Exception e) { | ||
| closePromise.completeExceptionally(e); |
Contributor
There was a problem hiding this comment.
Yes, it still needs the following operations. Catch this exception just to ensure the closePromise can complete.
eolivelli
requested changes
Jul 26, 2022
| try { | ||
| errorOutPendingAdds(rc, pendingAdds); | ||
| } catch (Exception e) { | ||
| closePromise.completeExceptionally(e); |
Contributor
There was a problem hiding this comment.
we shouldn't "completeExceptionally" or "complete" the closePromise twice
| errorOutPendingAdds(rc, pendingAdds); | ||
| try { | ||
| errorOutPendingAdds(rc, pendingAdds); | ||
| } catch (Exception e) { |
Contributor
There was a problem hiding this comment.
what about catching "Throwable" ?
Contributor
Author
|
@eolivelli Fixed, please check again. |
dlg99
approved these changes
Jul 28, 2022
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…nter exception (apache#2913) * Make sure the LedgerHandle close callback can be completed when encounter exception. (cherry picked from commit 05ca058)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…nter exception (apache#2913) * Make sure the LedgerHandle close callback can be completed when encounter exception. (cherry picked from commit 05ca058)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
…nter exception (apache#2913) * Make sure the LedgerHandle close callback can be completed when encounter exception. (cherry picked from commit 05ca058) (cherry picked from commit d8484b4)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…nter exception (apache#2913) * Make sure the LedgerHandle close callback can be completed when encounter exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to apache/pulsar#12993