Skip to content

Backport BookieBackpressureForV2Test to branch-4.14 - #3443

Merged
eolivelli merged 1 commit into
apache:branch-4.14from
lhotari:lh-backport-BookieBackpressureForV2Test-to-branch-4.14
Aug 16, 2022
Merged

Backport BookieBackpressureForV2Test to branch-4.14#3443
eolivelli merged 1 commit into
apache:branch-4.14from
lhotari:lh-backport-BookieBackpressureForV2Test-to-branch-4.14

Conversation

@lhotari

@lhotari lhotari commented Aug 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

branch-4.14 fails to compile with this error message:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project bookkeeper-server: Compilation failure
[ERROR] /home/lari/workspace-pulsar/bookkeeper/bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/BookieBackpressureForV2Test.java:[34,9] cannot find symbol
[ERROR]   symbol:   method confByIndex(int)
[ERROR]   location: class org.apache.bookkeeper.proto.BookieBackpressureForV2Test

Changes

@lhotari lhotari mentioned this pull request Aug 9, 2022
Merged
@lhotari
Backport BookieBackpressureForV2Test to branch-4.14
4187ea8 
- cherry-picking apache#3324 requires this backport
@lhotari
lhotari force-pushed the lh-backport-BookieBackpressureForV2Test-to-branch-4.14 branch from 9cfd847 to 4187ea8 Compare August 9, 2022 17:20
StevenLuMT
StevenLuMT approved these changes Aug 10, 2022
View reviewed changes

@StevenLuMT StevenLuMT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StevenLuMT

StevenLuMT commented Aug 10, 2022

Copy link
Copy Markdown
Member

rerun failure checks

@eolivelli

eolivelli commented Aug 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@nicoloboschi @michaeljmarshall @zymap @merlimat
TLS tests are failing, this is unrelated to this change.

I am committing the patch because we have to unblock that test

@eolivelli
eolivelli merged commit fe0bc2d into apache:branch-4.14 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eolivelli eolivelli eolivelli approved these changes
@zymap zymap zymap approved these changes
@StevenLuMT StevenLuMT StevenLuMT approved these changes
+1 more reviewer
@michaeljmarshall michaeljmarshall michaeljmarshall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lhotari lhotari

Labels

release/4.14.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lhotari @StevenLuMT @eolivelli @zymap @michaeljmarshall