Add latency stats for entry location index lookup so that possible RocksDB bottleneck can be detected#3444
Merged
eolivelli merged 3 commits intoAug 16, 2022
Conversation
- this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed
lhotari
force-pushed
the
lh-add-metric-for-entry-location-lookup
branch
from
August 10, 2022 07:56
8383e47 to
f315686
Compare
michaeljmarshall
suggested changes
Aug 10, 2022
StevenLuMT
reviewed
Aug 10, 2022
michaeljmarshall
approved these changes
Aug 10, 2022
zymap
approved these changes
Aug 11, 2022
hangc0276
reviewed
Aug 11, 2022
hangc0276
left a comment
Contributor
There was a problem hiding this comment.
We already have the index lookup stats read-locations-index-time, does it has any case this metric can't cover?
lhotari
marked this pull request as draft
August 11, 2022 16:55
Member
Author
thanks for pointing that out @hangc0276 . The problem with the |
lhotari
marked this pull request as ready for review
August 11, 2022 17:04
zymap
pushed a commit
that referenced
this pull request
Sep 21, 2022
…cksDB bottleneck can be detected (#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7)
hangc0276
pushed a commit
to hangc0276/bookkeeper
that referenced
this pull request
Nov 7, 2022
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7)
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jan 11, 2023
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name (cherry picked from commit 19fd8f7) (cherry picked from commit d2d8194)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…cksDB bottleneck can be detected (apache#3444) * Add operation latency stats for entry location lookup - this metric will help detecting when the bottleneck is in the entry location index lookup operations and RocksDB tuning is needed * Address review feedback: fix issue with eventLatencyMillis variable * Rename misleading parameter name
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
and RocksDB tuning is needed
Changes
Add new operation latency metrics
lookup-entry-locationwhich will be provided at the same level of metrics as the existingentries-countmetric.