Skip to content

Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zymap merged 1 commit into from
Aug 24, 2022
Merged

Fix group ForceWrite not take effect with forceWriteMarkerSent in while loop of ForceWriteThread #3454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,9 +511,9 @@ public void run() {
boolean shouldForceWrite = true;
int numReqInLastForceWrite = 0;
long busyStartTime = System.nanoTime();
boolean forceWriteMarkerSent = false;

@StevenLuMT StevenLuMT Aug 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line:563 affects judgment @zymap

bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java

Line 563 in 149ecd9

&& forceWriteMarkerSent

@zymap zymap Aug 23, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I got it

while (running) {
ForceWriteRequest req = null;
boolean forceWriteMarkerSent = false;
try {
forceWriteThreadTime.add(MathUtils.elapsedNanos(busyStartTime));
req = forceWriteRequests.take();
Expand Down