Skip to content

AutoRecovery - Do not call shutdown() on the main ZookKeeper client thread #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoloboschi merged 1 commit into from
Sep 14, 2022
Merged

AutoRecovery - Do not call shutdown() on the main ZookKeeper client thread #3487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.io.IOException;
import java.lang.Thread.UncaughtExceptionHandler;
import java.net.MalformedURLException;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import org.apache.bookkeeper.bookie.BookieCriticalThread;
import org.apache.bookkeeper.bookie.BookieImpl;
Expand Down Expand Up @@ -94,7 +95,11 @@ public AutoRecoveryMain(ServerConfiguration conf, StatsLogger statsLogger)
MetadataClientDriver metadataClientDriver = bkc.getMetadataClientDriver();
metadataClientDriver.setSessionStateListener(() -> {
LOG.error("Client connection to the Metadata server has expired, so shutting down AutoRecoveryMain!");
shutdown(ExitCode.ZK_EXPIRED);
// do not run "shutdown" in the main ZooKeeper client thread
// as it performs some blocking operations
CompletableFuture.runAsync(() -> {
shutdown(ExitCode.ZK_EXPIRED);
});
});

auditorElector = new AuditorElector(
Expand Down