Skip to content

Add a judgement of waitTimeoutOnResponseBackpressureMs when throttling read response - #3599

Closed
gaozhangmin wants to merge 1 commit into
apache:masterfrom
gaozhangmin:throttle
Closed

Add a judgement of waitTimeoutOnResponseBackpressureMs when throttling read response#3599
gaozhangmin wants to merge 1 commit into
apache:masterfrom
gaozhangmin:throttle

Conversation

@gaozhangmin

Copy link
Copy Markdown
Contributor

#3324 made v2 request support back pressure, if we set waitTimeoutOnResponseBackpressureMs, it won't take effect, because readWorkerThreadsThrottlingEnabled is enabled by default,

@gaozhangmin

Copy link
Copy Markdown
Contributor Author

rerun failure checks

@zymap zymap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is different logic for them but they are trying to resolve the same problem. If you want to use the backpressure, you should know the throttle need to be disabled.

@gaozhangmin

gaozhangmin commented Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

Because it is different logic for them but they are trying to resolve the same problem. If you want to use the backpressure, you should know the throttle need to be disabled

For the most who don't be familiar with the code, they won't know back pressure need disabling throttle and even throttle is enabled by default. @zymap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants