Upgrade Netty to 4.1.86.Final - #3669
Merged
Merged
Conversation
nicoloboschi
approved these changes
Nov 24, 2022
lhotari
force-pushed
the
lh-upgrade-netty-4.1.85.Final
branch
from
November 24, 2022 10:18
81d80b2 to
c9ceb44
Compare
hezhangjian
approved these changes
Nov 24, 2022
Contributor
|
@lhotari Thanks for your contribution, please take a look at the license check, thanks. |
Member
Author
|
Netty 4.1.85.Final upgrade causes a regression in Pulsar. I have commented on the Netty change about this: netty/netty#12888 (comment) . It seems that there is a major change in behavior in Netty's HashedWheelTimer. |
hangc0276
requested changes
Nov 28, 2022
hangc0276
left a comment
hangc0276
left a comment
Contributor
There was a problem hiding this comment.
Waiting for Netty new release
lhotari
force-pushed
the
lh-upgrade-netty-4.1.85.Final
branch
from
December 12, 2022 17:56
c9ceb44 to
dd89aea
Compare
Member
Author
|
Upgraded to 4.1.86.Final which reverts the HashedWheelTimer change and includes some CVE fixes. See release notes for Netty changes. (referenced in PR description) |
Commands used to refresh licenses: cd bookkeeper-dist/src/main/resources/deps rm -rf netty-* mkdir netty-4.1.86.Final cd netty-4.1.86.Final curl -L -o - https://github.com/netty/netty/archive/refs/tags/netty-4.1.86.Final.tar.gz | tar -zxv --strip-components=2 --wildcards -f - '*/license/*' rm LICENSE.zstd-jni.txt LICENSE.brotli4j.txt cd .. git add netty-4.1.86.Final
lhotari
force-pushed
the
lh-upgrade-netty-4.1.85.Final
branch
from
December 15, 2022 12:15
ad747a4 to
5b8e96e
Compare
Member
Author
|
@hangc0276 Please re-review this PR and possibly also merge it. |
hangc0276
approved these changes
Jan 11, 2023
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
### Motivation - see release notes for 4.1.85.Final: https://netty.io/news/2022/11/09/4-1-85-Final.html - see release notes for 4.1.86.Final: https://netty.io/news/2022/12/12/4-1-86-Final.html It is unknown whether there are fixes that specifically target Netty features used in Bookkeeper. One of the motivation of this PR is to upgrade Netty in Bookkeeper when the Netty version gets upgraded in Pulsar. The PR for Netty 4.1.86.Final upgrade in Pulsar is apache/pulsar#18599 ### Changes Upgrade Netty version to 4.1.86.Final
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation - see release notes for 4.1.85.Final: https://netty.io/news/2022/11/09/4-1-85-Final.html - see release notes for 4.1.86.Final: https://netty.io/news/2022/12/12/4-1-86-Final.html It is unknown whether there are fixes that specifically target Netty features used in Bookkeeper. One of the motivation of this PR is to upgrade Netty in Bookkeeper when the Netty version gets upgraded in Pulsar. The PR for Netty 4.1.86.Final upgrade in Pulsar is apache/pulsar#18599 ### Changes Upgrade Netty version to 4.1.86.Final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It is unknown whether there are fixes that specifically target Netty features used in Bookkeeper. One of the motivation of this PR is to upgrade Netty in Bookkeeper when the Netty version gets upgraded in Pulsar. The PR for Netty 4.1.86.Final upgrade in Pulsar is apache/pulsar#18599
Changes
Upgrade Netty version to 4.1.86.Final