Fixed back API of Crc32cIntChecksum#3826
Merged
Merged
Conversation
codelipenghui
approved these changes
Mar 1, 2023
hangc0276
approved these changes
Mar 1, 2023
hezhangjian
approved these changes
Mar 1, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3826 +/- ##
============================================
+ Coverage 68.37% 68.39% +0.01%
- Complexity 6759 6760 +1
============================================
Files 473 473
Lines 40972 40972
Branches 5241 5241
============================================
+ Hits 28015 28021 +6
+ Misses 10699 10698 -1
+ Partials 2258 2253 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
### Motivation In apache#3810 the signature of `Crc32cIntChecksum.resumeChecksum()` was changed to accept `offset` & `len` in the buffer. Since this method is also used externally (in Pulsar), we should leave also the old method signature to avoid breaking the API when upgrading BK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #3810 the signature of
Crc32cIntChecksum.resumeChecksum()was changed to acceptoffset&lenin the buffer.Since this method is also used externally (in Pulsar), we should leave also the old method signature to avoid breaking the API when upgrading BK.