Skip to content

fix[rocksdb]: fix error rocksdb default config for CFOptions#4466

Merged
StevenLuMT merged 5 commits into
apache:masterfrom
AuroraTwinkle:fix/rocksdbConf
Jul 20, 2024
Merged

fix[rocksdb]: fix error rocksdb default config for CFOptions#4466
StevenLuMT merged 5 commits into
apache:masterfrom
AuroraTwinkle:fix/rocksdbConf

Conversation

@AuroraTwinkle

@AuroraTwinkle AuroraTwinkle commented Jul 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Descriptions of the changes in this PR:

Fix erros of rocksdb default config

Motivation

The default rocksdb config has some errors and need fix.

Changes

  1. Fix error rocksdb default config for CFOptions.
  2. Update rocksdb config for unit test

liangyepianzhou
liangyepianzhou approved these changes Jul 19, 2024
View reviewed changes

@liangyepianzhou liangyepianzhou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

StevenLuMT
StevenLuMT approved these changes Jul 19, 2024
View reviewed changes

@StevenLuMT StevenLuMT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, LGTM

@dlg99

dlg99 commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

The change broke KeyValueStorageRocksDBTest:

Error:  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile
Error:    Run 1: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 2: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 3: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>

@AuroraTwinkle

AuroraTwinkle commented Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

The change broke KeyValueStorageRocksDBTest:

Error:  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile
Error:    Run 1: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 2: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 3: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>

Thanks，I will fix all failed Testcases.

@StevenLuMT
StevenLuMT requested a review from dlg99 July 19, 2024 06:31
@AuroraTwinkle

AuroraTwinkle commented Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

The change broke KeyValueStorageRocksDBTest:

Error:  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile
Error:    Run 1: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 2: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>
Error:    Run 3: KeyValueStorageRocksDBTest.testRocksDBInitiateWithConfigurationFile:74 expected:<1> but was:<30>

I have fixed it.

@StevenLuMT
StevenLuMT merged commit 4ca020a into apache:master Jul 20, 2024
lhotari
lhotari reviewed Aug 15, 2024
View reviewed changes
Comment thread conf/entry_location_rocksdb.conf.default
@lhotari lhotari mentioned this pull request Aug 15, 2024
Merged
4 tasks
@lhotari lhotari added this to the 4.18.0 milestone Apr 16, 2025
lhotari pushed a commit that referenced this pull request Apr 16, 2025
@AuroraTwinkle duanlinlin @lhotari
fix[rocksdb]: fix error rocksdb default config for CFOptions (#4466)
d237f09 
* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
lhotari pushed a commit that referenced this pull request Apr 16, 2025
@AuroraTwinkle duanlinlin @lhotari
fix[rocksdb]: fix error rocksdb default config for CFOptions (#4466)
3b06ecf 
* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
@lhotari lhotari mentioned this pull request Apr 17, 2025
Merged
lhotari pushed a commit that referenced this pull request Apr 17, 2025
@AuroraTwinkle duanlinlin @lhotari
fix[rocksdb]: fix error rocksdb default config for CFOptions (#4466)
6d4942e 
* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
priyanshu-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 11, 2025
@AuroraTwinkle duanlinlin @priyanshu-ctds
fix[rocksdb]: fix error rocksdb default config for CFOptions (apache#…
d617507 
…4466)

* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
(cherry picked from commit d237f09)
sandeep-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 22, 2025
@AuroraTwinkle duanlinlin @sandeep-ctds
fix[rocksdb]: fix error rocksdb default config for CFOptions (apache#…
4222a01 
…4466)

* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
(cherry picked from commit d237f09)
manas-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Feb 27, 2026
@AuroraTwinkle duanlinlin @manas-ctds
fix[rocksdb]: fix error rocksdb default config for CFOptions (apache#…
af0642a 
…4466)

* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
(cherry picked from commit 3b06ecf)
dlg99 pushed a commit to datastax/bookkeeper that referenced this pull request Feb 27, 2026
@AuroraTwinkle duanlinlin @dlg99
fix[rocksdb]: fix error rocksdb default config for CFOptions (apache#…
a244f71 
…4466)

* fix[rocksdb]: fix error rocksdb default config for CFOptions

---------

Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>
(cherry picked from commit 4ca020a)
(cherry picked from commit 3b06ecf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari left review comments
@dlg99 dlg99 dlg99 approved these changes
@StevenLuMT StevenLuMT StevenLuMT approved these changes
@eolivelli eolivelli Awaiting requested review from eolivelli
@zymap zymap Awaiting requested review from zymap
@hezhangjian hezhangjian Awaiting requested review from hezhangjian
+1 more reviewer
@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-picked/branch-4.15 cherry-picked/branch-4.16 cherry-picked/branch-4.17 release/4.15.6 release/4.16.7 release/4.17.2

Projects

None yet

Milestone

4.18.0

Development

Successfully merging this pull request may close these issues.

6 participants

@AuroraTwinkle @dlg99 @lhotari @hezhangjian @StevenLuMT @liangyepianzhou