Fix and improve locating RocksDB config files#4560
Merged
Conversation
lhotari
requested review from
dlg99,
eolivelli,
hangc0276,
hezhangjian,
merlimat,
nicoloboschi and
zymap
March 5, 2025 14:28
Member
|
@eolivelli @dlg99 @zymap please review this pr |
dlg99
approved these changes
Apr 1, 2025
dlg99
left a comment
dlg99
left a comment
Contributor
There was a problem hiding this comment.
LGTM but since it is fixing a bug I think it deserves a test that reproes the problem
Member
|
Well, I added some test cases for the configuration of rocksdb before. |
eolivelli
approved these changes
Apr 2, 2025
lhotari
added a commit
that referenced
this pull request
Apr 16, 2025
(cherry picked from commit f34455b)
lhotari
added a commit
that referenced
this pull request
Apr 16, 2025
(cherry picked from commit f34455b)
lhotari
added a commit
that referenced
this pull request
Apr 17, 2025
(cherry picked from commit f34455b)
priyanshu-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The solution to locate RocksDB config files has been broken since #4407 in master branch.
Changes