Opt performance of async log#2602
Merged
Merged
Conversation
3d8503e to
820c72a
Compare
Contributor
|
LGTM |
Member
|
Hi, let's merge this? |
Contributor
Author
|
@wwbmmm 这个PR应该可以合了 |
Member
|
这里对日志时间的影响是可接收的吗? |
Contributor
Author
|
日志时间应该是跟原来一样的,只影响落盘时间。 Lines 1308 to 1314 in bdc141c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
目前异步日志(完全由异步线程落盘日志)的性能仅仅是同步日志的3倍左右,没达到每秒百万的级别。
通过cpu profiler分析发现,瓶颈在
PrintLogPrefix,特别是localtime_r或者localtime_s(有锁)。What is changed and the side effects?
Changed:
将
PrintLogPrefix逻辑后移到异步线程运行,加快LOG(xxx)的速度。优化后,异步日志性能得到了很大的提升,性能是同步日志的十几倍以上。
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: