Restrict BRPC_VALIDATE_GFLAG to global scope and namespace scope only#2625
Merged
Conversation
Contributor
|
有时候希望gflags的validator在第一次加载的时候不执行validator,因为validator里面的一些内容需要在程序起来后才能有效。 |
Contributor
Author
|
brpc/src/brpc/reloadable_flags.h Lines 27 to 29 in 7a8df46 从注释能看出,BRPC_VALIDATE_GFLAG的设计的初衷就是期望只在全局作用域调的。 如果需要在程序起来后起作用的话,自己调GFLAGS_NS::RegisterFlagValidator来注册回调函数就行了吧。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
限制BRPC_VALIDATE_GFLAG只能在全局作用域或者namespace中使用,避免注册失败导致运行中的进程退出了。
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: