Skip to content

Add virtual destructors to MongoServiceAdaptor and SpanFilter #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zyearn merged 3 commits into from
May 26, 2024
Merged

Add virtual destructors to MongoServiceAdaptor and SpanFilter #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c25299f
Add virtual destructors to MongoServiceAdaptor and SpanFilter
yozhao May 24, 2024
58c634f
Virtual desctructor in SpanFiler and MongoServiceAdaptor
yozhao May 24, 2024
8b92323
Add virtual destructors to MongoServiceAdaptor and SpanFilte
yozhao May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/brpc/mongo_service_adaptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ class MongoContextMessage : public InputMessageBase {

class MongoServiceAdaptor {
public:
virtual ~MongoServiceAdaptor() = default;

// Make an error msg when the cntl fails. If cntl fails, we must send mongo client a msg not
// only to indicate the error, but also to finish the round trip.
virtual void SerializeError(int response_to, butil::IOBuf* out_buf) const = 0;
Expand Down
1 change: 1 addition & 0 deletions src/brpc/span.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...);

class SpanFilter {
public:
virtual ~SpanFilter() = default;
virtual bool Keep(const BriefSpan&) = 0;
};

Expand Down