Fix tcp connect interrupt#2664
Merged
Merged
Conversation
d477324 to
f22a7b9
Compare
f22a7b9 to
c5f7da4
Compare
wwbmmm
reviewed
Jun 20, 2024
f92228f to
5edf24e
Compare
Contributor
Author
|
@wwbmmm 有空看看 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
tcp_connect被中断之后,返回结果是有问题的:
bthread_timed_connect / bthread_connect:butex_wait返回0,errno等于EWOULDBLOCK或者EINTR,最后tcp_connect返回一个未连接成功的socket fd。pthread_timed_connect:返回-1,errno等于EINTR。What is changed and the side effects?
Changed:
当errno等于
EWOULDBLOCK或者EINTR,pthread_fd_wait / bthread_fd_wait继续wait到连接成功或者失败。Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: