Fix compilation errors of SerializedResponse#2722
Merged
Merged
Conversation
7 tasks
Member
|
Protobuf 升级 API 时不时就会不兼容，这个看有没有什么办法做隔离？ |
Contributor
Author
|
只能跟着Protobuf版本兼容了吧。 |
Contributor
Author
|
目前bRPC内部继承并实现google::protobuf::Message的原因：
针对这两个问题，或许我们可以通过以下方法来接触对Protobuf的依赖。以下是初步的想法（可能还有其他未关注到得细节）：
|
Contributor
|
unreflectable_message.txt PS：最近pb的breaking change确实多 |
Member
@oathdruid 这个方便开源出来不？ |
wasphin
added a commit
that referenced
this pull request
Oct 13, 2024
See #2722 (comment) inspired by unreflectable_message of oathdruid.
wasphin
added a commit
that referenced
this pull request
Oct 13, 2024
See #2722 (comment) inspired by unreflectable_message of oathdruid.
wasphin
added a commit
that referenced
this pull request
Oct 13, 2024
See #2722 (comment) inspired by unreflectable_message of @oathdruid.
wasphin
added a commit
to wasphin/brpc
that referenced
this pull request
Oct 14, 2024
See apache#2722 (comment) inspired by unreflectable_message of @oathdruid.
wasphin
added a commit
to wasphin/brpc
that referenced
this pull request
Oct 14, 2024
See apache#2722 (comment) inspired by unreflectable_message of @oathdruid.
wasphin
added a commit
to wasphin/brpc
that referenced
this pull request
Oct 14, 2024
See apache#2722 (comment) inspired by unreflectable_message of @oathdruid.
wasphin
added a commit
to wasphin/brpc
that referenced
this pull request
Oct 16, 2024
See apache#2722 (comment) inspired by unreflectable_message of @oathdruid.
chenBright
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Add NonreflectableMessage and support Protobuf v5 See #2722 (comment) inspired by unreflectable_message of @oathdruid. * Remove unnecessary MessageHelper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #2721
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: