Send unauthorized response to client when authentication fails#2744
Merged
Conversation
wasphin
reviewed
Aug 24, 2024
chenBright
force-pushed
the
auth
branch
3 times, most recently
from
353c4ef to
6ddf5d5
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
当前server鉴权失败时，会直接关闭连接。client只有
EEOF的错误，没法快速定位问题。What is changed and the side effects?
Changed:
在
Authenticator增加一个接口，支持返回一个错误响应给client再关闭连接。Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: