Support semaphore and rwlock for bthread#2752
Merged
Merged
Conversation
wwbmmm
reviewed
Sep 3, 2024
Contributor
|
请问这个PR什么时候可以合入呢？ 对rwlock有需求，之前提个PR被反馈性能不好，希望尽快用上官方的实现 |
Contributor
Author
没那么快。读写锁的核心功能已经实现了，还有一些需要优化的地方。 |
chenBright
force-pushed
the
rwlock
branch
3 times, most recently
from
361afcc to
01e9fb0
Compare
Contributor
Author
|
@wwbmmm 再看看。整理了一下commit，分成三部分，review起来清晰一点。 |
Contributor
|
LGTM |
chenBright
changed the title
Contributor
Author
Closed
This was referenced Oct 31, 2024
Closed
Contributor
Author
@ketor 目前已经在使用了该rwlock实现了吗？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: