Skip to content

Support noncopyable sync objects#2766

Merged
lorinlee merged 1 commit into
apache:masterfrom
chenBright:noncopyable_sync
Sep 20, 2024
Merged

Support noncopyable sync objects#2766
lorinlee merged 1 commit into
apache:masterfrom
chenBright:noncopyable_sync

Conversation

@chenBright

@chenBright chenBright commented Sep 17, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

使用bthread_mutex、bthread_cond_t时,一旦不小心发现了拷贝,就会出现未定义行为。

What is changed and the side effects?

Changed:

在C++环境中,禁止bthread_mutex、bthread_cond_t拷贝。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm

wwbmmm commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

LGTM

@lorinlee lorinlee merged commit 8fa216c into apache:master Sep 20, 2024
@chenBright chenBright deleted the noncopyable_sync branch September 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants