Skip to content

Add missing #include <cstdint>#2800

Merged
wasphin merged 1 commit into
apache:masterfrom
Menci:master
Oct 30, 2024
Merged

Add missing #include <cstdint>#2800
wasphin merged 1 commit into
apache:masterfrom
Menci:master

Conversation

@Menci

@Menci Menci commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

It doesn't compile with GCC 13.

What is changed and the side effects?

Changed:

Adding missing #include <cstdint> for int64_t usage.

Side effects:

  • Performance effects(性能影响): N/A

  • Breaking backward compatibility(向后兼容性): N/A


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wasphin

wasphin commented Oct 29, 2024

Copy link
Copy Markdown
Member

maybe add in the header file?

@Menci

Menci commented Oct 29, 2024

Copy link
Copy Markdown
Contributor Author

@wasphin

A bit strange. brpc.h is not using <cstdint>, as it doesn't expose this API ConvertGrpcTimeoutToUS, while the caller in http_rpc_protocol.cpp declared this API manually:

// Defined in grpc.cpp
int64_t ConvertGrpcTimeoutToUS(const std::string* grpc_timeout);

@wwbmmm

wwbmmm commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

LGTM

@wasphin wasphin merged commit d12d41c into apache:master Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants