set tags workers unlimitedly#2801
Merged
Merged
Conversation
Contributor
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary: 设置 tag 对应的 worker 需要考虑 bthread_concurrency 和 bthread_min_concurrency，而且如果超过 bthread_concurrency 而又没有使用 bthread_min_concurrency 就无法正常设置 tag 对应的 worker 值，因为修改 bthread_concurrency 的值会直接平均分配给每一个 tag。
What is changed and the side effects?
Changed: 修改了增加 tag 对应 worker 的逻辑。
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: