Skip to content

method level option to ignore server eovercrowded#2820

Merged
chenBright merged 9 commits into
apache:masterfrom
superhail:brpc-method-level
Dec 4, 2024
Merged

method level option to ignore server eovercrowded#2820
chenBright merged 9 commits into
apache:masterfrom
superhail:brpc-method-level

Conversation

@superhail

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed: add a method-level option(only valid for baidu_rpc, http_rpc, hulu_pbrpc and sofa_pbrpc protocols) to enable ignore eovercrowded errors for some methods.

Side effects:

  • Performance effects(性能影响): no or little

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

Comment thread src/brpc/policy/baidu_rpc_protocol.cpp Outdated
Comment thread src/brpc/policy/http_rpc_protocol.cpp Outdated
Comment thread src/brpc/policy/hulu_pbrpc_protocol.cpp Outdated
Comment thread src/brpc/policy/sofa_pbrpc_protocol.cpp Outdated
Comment thread src/brpc/baidu_master_service.h Outdated
Comment thread src/brpc/server.h Outdated
Comment thread src/brpc/server.h Outdated
Comment thread src/brpc/server.cpp

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以补充一下server.md文档吗?

@superhail

Copy link
Copy Markdown
Contributor Author

好的,我补充一下

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@superhail

Copy link
Copy Markdown
Contributor Author

@wwbmmm please help review

Comment thread src/brpc/baidu_master_service.h Outdated
Comment thread src/brpc/server.h Outdated
@superhail

Copy link
Copy Markdown
Contributor Author

@wwbmmm cc

@wwbmmm

wwbmmm commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

LGTM

@chenBright chenBright merged commit f187d2c into apache:master Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants