Skip to content

keytablelist bugfix#2835

Merged
wwbmmm merged 1 commit into
apache:masterfrom
MJY-HUST:keytablelist_bugfix
Dec 6, 2024
Merged

keytablelist bugfix#2835
wwbmmm merged 1 commit into
apache:masterfrom
MJY-HUST:keytablelist_bugfix

Conversation

@MJY-HUST

@MJY-HUST MJY-HUST commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

之前实现的 move_first_n_to_target 有问题,如果target是一串链表的话会导致全局维护的free_keytables链表中除了头节点的剩余keytables丢失,造成内存泄漏。
单测负载不高没测出来,修复后在我们自己的场景中进行了测试,keytable的数量不会出现持续升高的情况。

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm wwbmmm merged commit 264ba31 into apache:master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants