Skip to content

Fix build failure with -std=c++17 option#2844

Merged
chenBright merged 1 commit into
apache:masterfrom
tongke6:tk/build-fix
Dec 12, 2024
Merged

Fix build failure with -std=c++17 option#2844
chenBright merged 1 commit into
apache:masterfrom
tongke6:tk/build-fix

Conversation

@tongke6

@tongke6 tongke6 commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

build fails when building with -std=c++17 on

image

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@tongke6 tongke6 changed the title fix: fix build failure with -std=c++17 option Fix build failure with -std=c++17 option Dec 12, 2024

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit 282bc90 into apache:master Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants