Fix/metric emission tracking #2825#2870
Closed
snehavats1404 wants to merge 5 commits into
Closed
Conversation
snehavats1404
changed the title
chenBright
reviewed
Jan 13, 2025
Comment on lines
+106
to
+110
| if(emitted_metrics.find(metrics_name.as_string()) == emitted_metrics.end()){ | ||
| *_os<< "# HELP " << metrics_name <<'\n' | ||
| << "# TYPE " << metrics_name <<" gauge\n"; | ||
| emitted_metrics.insert(metrics_name.as_string()); | ||
| } |
Contributor
There was a problem hiding this comment.
Some spaces are missing.
Contributor
|
Author
|
I don't feel there must be any issue in not adding any unit testcase, if there is any please let me know. |
Contributor
We hope that PR will be equipped with unit tests as much as possible to ensure correctness. |
Contributor
|
Close this as completed in #2899 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2825
Problem Summary:
The issue pertains to incorrectly tracking and emitting metric names when dumping Prometheus metrics. Some metrics, especially those related to latency, were not being properly emitted due to incorrect handling of the
emitted_metricsset.What is changed and the side effects?
Changed:
_latency_*and_countsuffixes.Side effects: