Skip to content

fix memory leak issue #2871#2872

Merged
chenBright merged 6 commits into
apache:masterfrom
w-gc:master
Jan 29, 2025
Merged

fix memory leak issue #2871#2872
chenBright merged 6 commits into
apache:masterfrom
w-gc:master

Conversation

@w-gc

@w-gc w-gc commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: #2871

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright linked an issue Jan 13, 2025 that may be closed by this pull request
Comment thread src/brpc/server.cpp Outdated
@chenBright

Copy link
Copy Markdown
Contributor

This PR caused the BuiltinServiceTest.customized_health unit test to fail.

Comment thread src/brpc/server.cpp
Comment thread src/brpc/server.cpp Outdated
Comment thread src/brpc/server.cpp Outdated
@w-gc w-gc requested a review from chenBright January 20, 2025 02:50

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/brpc/server.cpp Outdated
Comment thread src/brpc/server.cpp Outdated
Comment thread src/brpc/server.cpp
@w-gc w-gc requested a review from yanglimingcn January 23, 2025 03:43
@w-gc w-gc requested a review from chenBright January 24, 2025 05:00

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit f657257 into apache:master Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Memory leak about ServerOptions

3 participants