Support segment large brpc stream messages automatically#2889
Merged
chenBright merged 1 commit intoFeb 17, 2025
Conversation
jenrryyou
force-pushed
the
brpc_auto_semgent_stream_message
branch
3 times, most recently
from
898b114 to
4f986a5
Compare
wwbmmm
reviewed
Feb 9, 2025
jenrryyou
force-pushed
the
brpc_auto_semgent_stream_message
branch
2 times, most recently
from
c88748e to
97f4ca5
Compare
Contributor
|
LGTM |
jenrryyou
force-pushed
the
brpc_auto_semgent_stream_message
branch
from
97f4ca5 to
41fb784
Compare
Contributor
Author
|
辛苦大佬@wwbmmm @chenBright 有空点下merge |
chenBright
reviewed
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
https://github.com/apache/incubator-brpc/blob/master/docs/cn/streaming_rpc.md
"目前的实现还没有自动切割过大的消息，同一个tcp连接上的多个Stream之间可能有Head-of-line blocking问题，请尽量避免过大的单个消息，实现自动切割后我们会告知并更新文档"
尝试解决这个 TODO。
之前#1947 这个MR存在一点问题（见 讨论和comment）一直没有合入。最近内部有很多业务有需求，我重新实现了下。