Skip to content

[#2913] fix link error if with glog#2914

Merged
chenBright merged 1 commit into
apache:masterfrom
ivanallen:fix-2913
Mar 20, 2025
Merged

[#2913] fix link error if with glog#2914
chenBright merged 1 commit into
apache:masterfrom
ivanallen:fix-2913

Conversation

@ivanallen

@ivanallen ivanallen commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: #2913

Problem Summary:

glog 依赖 gflags,静态链接的时候,glfags 必须在 glog 后面,否则可能会链接错误

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

Signed-off-by: allen <allen@qq.com>
@wwbmmm

wwbmmm commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@yanglimingcn

Copy link
Copy Markdown
Contributor

LGTM

@chenBright chenBright merged commit 2447f18 into apache:master Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants