Skip to content

support dynamic update method concurrency#2923

Merged
zyearn merged 1 commit into
apache:masterfrom
yanglimingcn:feature/method_concurrency_online_update
Mar 30, 2025
Merged

support dynamic update method concurrency#2923
zyearn merged 1 commit into
apache:masterfrom
yanglimingcn:feature/method_concurrency_online_update

Conversation

@yanglimingcn

@yanglimingcn yanglimingcn commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: #2873

目前只实现了ConstantConcurrencyLimiter的动态修改。

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

Comment thread src/brpc/policy/auto_concurrency_limiter.cpp Outdated
Comment thread src/brpc/policy/timeout_concurrency_limiter.cpp Outdated
Comment thread src/brpc/server.h Outdated
@yanglimingcn yanglimingcn force-pushed the feature/method_concurrency_online_update branch 2 times, most recently from 616428b to bdd0238 Compare March 24, 2025 12:02
Comment thread src/brpc/details/method_status.h Outdated
Comment thread src/brpc/adaptive_max_concurrency.cpp
@yanglimingcn yanglimingcn force-pushed the feature/method_concurrency_online_update branch from bdd0238 to 7903e9a Compare March 25, 2025 09:27
@wwbmmm

wwbmmm commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

LGTM

@chenBright chenBright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们这边也是类似的实现。

LGTM

@zyearn zyearn merged commit bf88565 into apache:master Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants