Skip to content

Fix double free messages in baidu-std#2924

Merged
chenBright merged 1 commit into
apache:masterfrom
chenBright:fix_baidu_std_core
Mar 23, 2025
Merged

Fix double free messages in baidu-std#2924
chenBright merged 1 commit into
apache:masterfrom
chenBright:fix_baidu_std_core

Conversation

@chenBright

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

SendRpcResponse中会统一归还messages,不需要在ProcessRpcRequest中提前归还。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wwbmmm

wwbmmm commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

LGTM

@chenBright chenBright merged commit 5c8bd06 into apache:master Mar 23, 2025
@chenBright chenBright deleted the fix_baidu_std_core branch March 23, 2025 06:07
@feng-y

feng-y commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

parse 失败会在什么场景下触发呢?

@chenBright

Copy link
Copy Markdown
Contributor Author

parse 失败会在什么场景下触发呢?

pb反序列化失败或者解压失败之类的吧。

@feng-y

feng-y commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

请求都是client send 的, 从代码上看应该是parse 失败,想了解根因,什么场景下会导致 parse 失败?网络错误,超时,或者 server 内部的一些错误

@chenBright

Copy link
Copy Markdown
Contributor Author

一般是client发的请求包有问题导致的吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants