Skip to content

Fix class data for protobuf v27+ #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wasphin merged 1 commit into from
Apr 7, 2025
Merged

Fix class data for protobuf v27+ #2941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 70 additions & 3 deletions src/brpc/nonreflectable_message.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,20 @@ class NonreflectableMessage : public ::google::protobuf::Message {
}

#if GOOGLE_PROTOBUF_VERSION >= 5029000
const ::google::protobuf::internal::ClassData* GetClassData() const override {
return nullptr;
}
using ClassData = ::google::protobuf::internal::ClassData;
using ClassDataFull = ::google::protobuf::internal::ClassDataFull;
#elif GOOGLE_PROTOBUF_VERSION >= 5026000
using ClassData = ::google::protobuf::Message::ClassData;
using ClassDataFull = ::google::protobuf::Message::ClassDataFull;
#endif

#if GOOGLE_PROTOBUF_VERSION >= 5026000
const ClassData* GetClassData() const override {
# if GOOGLE_PROTOBUF_VERSION >= 5027000
return _class_data_.base();
# else
return nullptr;
# endif
}
#endif

Expand Down Expand Up @@ -210,8 +218,67 @@ class NonreflectableMessage : public ::google::protobuf::Message {

private:
static T _instance;

#if GOOGLE_PROTOBUF_VERSION >= 5027000
struct NonreflectableMessageClassData : ClassDataFull {
constexpr NonreflectableMessageClassData()
: ClassDataFull(
# if GOOGLE_PROTOBUF_VERSION >= 5029000
ClassData{
&_instance, // prototype
nullptr, // tc_table
nullptr, // on_demand_register_arena_dtor
nullptr, // is_initialized
nullptr, // merge_to_from
::google::protobuf::internal::MessageCreator(), // message_creator
0, // cached_size_offset
false, // is_lite
},
nullptr, // descriptor_methods
nullptr, // descriptor_table
nullptr // get_metadata_tracker
# elif GOOGLE_PROTOBUF_VERSION >= 5028000
ClassData{
&_instance, // prototype
nullptr, // tc_table
nullptr, // on_demand_register_arena_dtor
nullptr, // is_initialized
nullptr, // merge_to_from
0, // cached_size_offset
false, // is_lite
},
nullptr, // descriptor_methods
nullptr, // descriptor_table
nullptr // get_metadata_tracker
# else
ClassData{
nullptr, // tc_table
nullptr, // on_demand_register_arena_dtor
nullptr, // is_initialized
0, // cached_size_offset
false, // is_lite
},
nullptr, // merge_to_from
nullptr, // descriptor_methods
nullptr, // descriptor_table
nullptr // get_metadata_tracker
# endif
) {
// Only can be used to determine whether the Types are the same.
descriptor = default_instance().GetMetadata().descriptor;
reflection = default_instance().GetMetadata().reflection;
}
};

static const NonreflectableMessageClassData _class_data_;
#endif
};

#if GOOGLE_PROTOBUF_VERSION >= 5027000
template <typename T>
const typename NonreflectableMessage<T>::NonreflectableMessageClassData NonreflectableMessage<T>::_class_data_;
#endif

template <typename T>
T NonreflectableMessage<T>::_instance;

Expand Down